From 9d7e2765243e863eed04c2cc39e4be05d6cdd2f1 Mon Sep 17 00:00:00 2001 From: David Griffith Date: Wed, 5 Mar 2025 09:51:03 -0800 Subject: [PATCH] Fixed potential out-of-bounds read in gen_blorb_init(). MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Thanks go to Petter Sjölund for pointing out that Address Sanitizer flagged that line as problematic. --- src/sdl/generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sdl/generic.c b/src/sdl/generic.c index 63d5db0..e9d0d22 100644 --- a/src/sdl/generic.c +++ b/src/sdl/generic.c @@ -108,7 +108,7 @@ bb_err_t gen_blorb_init(char *filename) else { /* Determine default Blorb file name. */ mystring = malloc(MAX(len1, len2) * sizeof(char) + 1); - memcpy(mystring, filename, MAX(len1, len2) * sizeof(char)); + memcpy(mystring, filename, strlen(filename) + 1); p = strrchr(mystring, '.'); if (p != NULL) *p = '\0'; -- 2.34.1